Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

D/I suggestName #2414

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

D/I suggestName #2414

wants to merge 2 commits into from

Conversation

adkian-sifive
Copy link
Contributor

@adkian-sifive adkian-sifive commented Feb 14, 2022 •
edited
Loading

Fixes #2366, draft until issue with name sanitization (here) is fixed

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • new feature/API

API Impact

Adds suggestName API for hierarchy instances

Backend Code Generation Impact

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference.

Release Notes

TODO

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

mwachs5
mwachs5 reviewed Feb 14, 2022
View reviewed changes
src/test/scala/chiselTests/experimental/hierarchy/InstanceSpec.scala
val inst0 = Instance(definition)
val inst1 = Instance(definition)
inst0.suggestName("potato")
inst1.suggestName("potato")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you show a test with two different things that are not the same Definition, Instance which also name conflict and successfully sanitize?

val inst0 = Module(new AddOne()).suggestName("potato")
val inst1 = Instance(definition).suggestName("potato")

@tymcauley tymcauley mentioned this pull request Dec 13, 2022
Merged
16 tasks
jackkoenig pushed a commit that referenced this pull request Feb 28, 2023
@scala-steward @mergify
Update sbt-scalafix to 0.9.32 (#2414)
4af6cf6 
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This was referenced Jan 10, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwachs5 mwachs5 mwachs5 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hierarchy API doesn't allow custom instance names
2 participants
@adkian-sifive @mwachs5